1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 03:20:59 +01:00
phorge-phorge/src/applications/phid
epriestley 7acda7e94e Truncate package names in diff table of contents views
Summary:
Ref T13151. See PHI654. Depends on D19477. If you have long package names, the table of contents (e.g., in Differential) can end up expanding to be gigantic.

Getting tables to behave nicely is hard (or, at least, I can't figure it out after spending a decent amount of time on it; see also `AphrontTableView::renderSingleDisplayLine()`). I tried a bunch of things and Googled for a bit but didn't make any progress on finding a CSS solution. Just truncate the package names to get reasonable behavior without falling down any kind of CSS rabbit hole.

Test Plan:
  - Created a package named "Very long package name...".
  - Created a package named "MMMMMMMMMMMMMMMMMMMMMM...".
  - Had them own a file in a Differential revision, viewed that revision.
  - Before: table is pushed out to several times the browser window width and everything is kind of a mess.
  - After: package names get truncated to something reasonable.

{F5652953}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19478
2018-06-07 13:17:01 -07:00
..
conduit phtize all the things 2015-05-22 21:16:39 +10:00
handle Fix spelling 2017-10-09 10:48:04 -07:00
interface Work around a bug in PHP 5.3-ish with abstract methods in interfaces 2013-10-25 15:58:17 -07:00
query Make restricted objects in commit messages work more consistently with the web UI 2017-01-01 09:56:47 -08:00
remarkup Remarkup rule for rendering PHIDs as handles 2016-03-17 20:24:03 +00:00
resolver Fix spelling 2017-10-09 10:48:04 -07:00
storage Remove some unused properties 2015-06-17 20:41:52 +10:00
type Use PhabricatorCachedClassMapQuery when querying object PHID types 2016-12-06 09:10:29 -08:00
view Truncate package names in diff table of contents views 2018-06-07 13:17:01 -07:00
PhabricatorMetaMTAApplicationEmailPHIDType.php Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
PhabricatorObjectHandle.php Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention 2018-02-06 04:04:52 -08:00
PhabricatorPHIDConstants.php Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
utils.php Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00