mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-14 19:02:41 +01:00
08bcb8c30a
Summary: I broke this a bit a few revisions ago by making `phabricator_render_csrf_magic()` return array instead of string without actually grepping for callsites. Instead of building a form in JS, build it in PHP and just change its action in JS. This is simpler and doesn't require us to expose CSRF magic in more places. This change triggered a rather subtle bug: if we rendered a normal form on the page (and thus installed the "disable forms when submitted" behavior), the download button would incorrectly disable after being clicked. This doesn't currently happen in Files because we don't put a form on the same page as the download button. Instead, make the "disable" behavior check if the form is downloading stuff, and not disable stuff if it is. Then mark the lightbox and Files form as both download forms. Test Plan: Used lightbox; used Files. Verified download buttons download the right stuff and behave correctly. Grepped for other download forms, but all the other places where we write "download" don't appear to actually be download links. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4685 |
||
|---|---|---|
| .. | ||
| PhabricatorFileController.php | ||
| PhabricatorFileDataController.php | ||
| PhabricatorFileDeleteController.php | ||
| PhabricatorFileDropUploadController.php | ||
| PhabricatorFileInfoController.php | ||
| PhabricatorFileListController.php | ||
| PhabricatorFileShortcutController.php | ||
| PhabricatorFileTransformController.php | ||
| PhabricatorFileUploadController.php | ||