mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-28 00:10:57 +01:00
No description
cac26c8824
Summary: Fixes T10912. When you drag tasks within a milestone, we currently apply an overbroad, API-focused rule and add the parent board's project. This logic was added fairly recently, as part of T6027, to improve the behavior of API-originated moves. Later on, this causes the task to toggle in and out of the parent project on every alternate drag. This logic is also partially duplicated in the `MoveController`. - Add test coverage for this interaction. - Fix the logic so it accounts for subproject / milestone columns correctly. - Put all of the logic into the TransactionEditor, so the API gets the exact same rules. Test Plan: - Added a failing test and made it pass. - Dragged tasks around within a milestone column: - Before patch: they got bogus project swaps on every other move. - After patch: projects didn't change (correct). - Dragged tasks around between normal and milestone columns. - Before patch: worked properly. - After patch: still works properly. Here's what the bad changes look like, the task is swapping projects with every other move: {F1255957} The "every other" is because the logic was trying to do this: - Add both the parent and milestone project. - Whichever one exists already gets dropped from the change list because it would have no effect. - The other one then applies. - In applying, it forces removal of the first one. - Then this process repeats in the other direction the next time through. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10912 Differential Revision: https://secure.phabricator.com/D15834 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| webroot | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.