mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 03:50:54 +01:00
cb1d904654
Summary:
Two little issues
1. there was an extra call to getHostForWrite,
2. The engine instance was shared between multiple service definitions so it
was overwriting the list of writable hosts from one service with hosts from another.
Test Plan:
tested in wikimedia production with multiple services defined like this:
```language=json
[
{
"hosts": [
{
"host": "search.svc.codfw.wmnet",
"protocol": "https",
"roles": {
"read": true,
"write": true
},
"version": 5
}
],
"path": "/phabricator",
"port": 9243,
"type": "elasticsearch"
},
{
"hosts": [
{
"host": "search.svc.eqiad.wmnet",
"protocol": "https",
"roles": {
"read": true,
"write": true
},
"version": 5
}
],
"path": "/phabricator",
"port": 9243,
"type": "elasticsearch"
}
]
```
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D17581
|
||
|---|---|---|
| .. | ||
| application | ||
| applicationpanel | ||
| buckets | ||
| constants | ||
| controller | ||
| editor | ||
| engine | ||
| engineextension | ||
| exception | ||
| field | ||
| fulltextstorage | ||
| index | ||
| interface | ||
| management | ||
| menuitem | ||
| ngrams | ||
| phidtype | ||
| query | ||
| relationship | ||
| storage | ||
| typeahead | ||
| view | ||
| worker | ||