1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-18 18:51:12 +01:00
phorge-phorge/src/infrastructure/query
epriestley cb4add3116 In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field
Summary:
Fixes T13345. See D20650. Currently, `PhabricatorCursorPagedPolicyAwareQuery` does a JOIN against the "title" field so it can apply additional ranking/ordering conditions to the query.

This means that documents with no title (which don't have this field) are always excluded from the result set.

We'd prefer to include them, just not give them any bonus ranking/relevance boost. Use a LEFT JOIN so they get included.

Test Plan:
  - Applied D20650 (diff 1), made it use raw `getTitle()` as the document title, indexed a paste with no title.
  - Searched for a term in the paste body.
  - Before change: no results.
  - After change: found result.

{F6601159}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13345

Differential Revision: https://secure.phabricator.com/D20660
2019-07-18 10:37:36 -07:00
..
constraint Support some QueryConstraint operations against generic ApplicationSearch query logic 2018-02-22 12:49:49 -08:00
exception Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer 2019-03-19 13:04:07 -07:00
order Drive Maniphest grouping and ordering through standard infrastructure 2015-06-08 12:23:13 -07:00
policy In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field 2019-07-18 10:37:36 -07:00
PhabricatorOffsetPagedQuery.php Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00
PhabricatorQuery.php Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00