mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 12:00:55 +01:00
No description
cb545856a9
Summary: See discussion in D8773. Three small adjustments which should help prevent this kind of issue: - When queueing followup tasks, hold them on the worker until we finish the task, then queue them only if the work was successful. - Increase the default lease time from 60 seconds to 2 hours. Although most tasks finish in far fewer than 60 seconds, the daemons are generally stable nowadays and these short leases don't serve much of a purpose. I think they also date from an era where lease expiry and failure were less clearly distinguished. - Increase the default wait-after-failure from 60 seconds to 5 minutes. This largely dates from the MetaMTA era, where Facebook ran services with high failure rates and it was appropriate to repeatedly hammer them until things went through. In modern infrastructure, such failures are rare. Test Plan: - Verified that tasks queued properly after the main task was updated. - Verified that leases default to 7200 seconds. - Intentionally failed a task and verified default 300 second wait before retry. - Removed all default leases shorter than 7200 seconds (there was only one). - Checked all the wait before retry implementations for anything much shorter than 5 minutes (they all seem reasonable). Reviewers: btrahan, sowedance Reviewed By: sowedance Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8774 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| webroot | ||
| .arcconfig | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README | ||
Phabricator is an open source collection of web applications which help software companies build better software. Phabricator includes applications for: - reviewing and auditing source code; - hosting and browsing repositories; - assembling a party to venture forth; - tracking bugs; - hiding stuff from coworkers; and - also some other things. You can learn more about the project (and find links to documentation and resources) here: http://phabricator.org/ Phabricator is developed and maintained by Phacility. The first version of Phabricator was originally built at Facebook. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted.