1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
phorge-phorge/src
Andre Klapper cb934602c2 Fix PHP 8.1 "strlen(null)" exception creating a Portal
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php:34]
```

Closes T15847

Test Plan: Go to `/portal/edit/form/default/`, set a name and click `Create Portal`.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15847

Differential Revision: https://we.phorge.it/D25681
2024-06-05 17:18:17 +02:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Correct PHPDoc or add default return for numerous methods 2024-05-18 21:54:51 +02:00
applications Fix PHP 8.1 "strlen(null)" exception creating a Portal 2024-06-05 17:18:17 +02:00
docs docs/file_domain: Update cloudflare spelling and URLs 2024-05-07 13:01:39 +00:00
extensions
infrastructure Remove broken link to PhutilHighIntensityIntervalDaemon docs 2024-06-04 17:31:38 -04:00
view Curtain: add Hovercard support 2023-12-10 16:55:14 +01:00
__phutil_library_init__.php Rebrand: Rename library and update "version" logic 2022-08-25 01:26:21 -07:00
__phutil_library_map__.php Show login page if a search token requires a valid viewer 2024-06-04 16:10:50 +02:00