1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
phorge-phorge/src/applications/differential/view
epriestley 3700bcb638 Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline
Summary:
See PHI180. Currently, if you begin creating or editing an inline and then swap display modes (for example, with "View Unified"), your edit is lost.

Persisting the editor state is complicated and this is very rare, so just prevent the action and warn the user instead.

Also make the warning persist for a little longer since a few of the messages, including this one, take a couple seconds to read now.

Test Plan:
  - Edited a comment, tried to swap display modes, got a warning.
  - Swapped display modes normally with no comment being edited.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18774
2017-11-15 10:02:48 -08:00
..
DifferentialChangesetDetailView.php Remove Differential "objectives" UI 2017-05-30 17:58:49 -07:00
DifferentialChangesetFileTreeSideNavBuilder.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
DifferentialChangesetListView.php Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline 2017-11-15 10:02:48 -08:00
DifferentialLocalCommitsView.php Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions" 2016-06-30 18:50:52 -07:00
DifferentialReviewersView.php Refine bucketing and display rules for voided "Accepts" in Differential 2017-11-07 15:35:11 -08:00
DifferentialRevisionListView.php Continue reducing callsites to ArcanistDifferentialRevisionStatus 2017-08-09 11:05:22 -07:00
DifferentialRevisionUpdateHistoryView.php Show broken units in revision history 2016-09-02 10:29:29 -07:00
DifferentialTransactionView.php Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00