1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 17:02:41 +01:00
phorge-phorge/src/infrastructure
epriestley 9125095587 Distinguish between empty and unparsed commits in Diffusion
Summary:
Fixes T3416. Fixes T1733.

  - Adds a flag to the commit table showing whether or not we have parsed it.
  - The flag is set to `0` initially when the commit is discovered.
  - The flag is set to `1` when the changes are parsed.
  - The UI can now use the flag to distinguish between "empty commit" and "commit which we haven't imported changes for yet".
  - Simplify rendering code a little bit.
  - Fix an issue with the Message parser for empty commits.
  - There's a key on the flag so we can do `SELECT * FROM repository_commit WHERE repositoryID = %d AND importStatus = 0 LIMIT 1` soon, to determine if a repository is fully imported or not. This will let us improve the UI (Ref T776, Ref T3217).

Test Plan:
  - Ran `bin/storage upgrade -f`.
  - Created an empty commit.
  - Without the daemons running, ran `bin/repository pull GTEST` and `bin/repository discover GTEST`.
  - Viewed web UI to get the first screenshot ("Still Importing...").
  - Ran the message and change steps with `scripts/repository/reparse.php`.
  - Viewed web UI to get the second screenshot ("Empty Commit").

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T776, T1733, T3416, T3217

Differential Revision: https://secure.phabricator.com/D7428
2013-10-29 15:32:41 -07:00
..
__tests__ In unit test environments, install all applications 2013-05-16 12:25:26 -07:00
celerity White hover policy icons 2013-10-23 10:16:09 -07:00
customfield PHUIPropertyListView 2013-10-11 07:53:56 -07:00
daemon Remove PhabricatorRepository::loadAllByPHIDOrCallsign() 2013-09-26 12:36:24 -07:00
diff Don't fatal with error in transaction diff 2013-04-16 08:41:36 -07:00
edges Allow projects to review revisions 2013-10-05 14:10:46 -07:00
env Fix controller-level access rules 2013-10-03 19:05:47 -07:00
events Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
internationalization Add project history and title strings 2013-10-22 13:49:37 -07:00
javelin Add Link button to Remarkup assist 2013-10-17 18:57:40 -07:00
lint Remove deprecated javelin_render_tag() and phabricator_render_form() 2013-07-18 13:30:25 -07:00
markup Make remarkup rules runtime-pluggable in a reasonable way 2013-10-24 17:26:07 -07:00
query Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
ssh Serve Git reads over SSH 2013-10-29 15:32:40 -07:00
storage Distinguish between empty and unparsed commits in Diffusion 2013-10-29 15:32:41 -07:00
testing Fix controller-level access rules 2013-10-03 19:05:47 -07:00
time Consolidate some datetime code and add unit tests 2013-06-03 12:58:11 -07:00
util Proof of concept mitigation of BREACH 2013-08-07 16:09:05 -07:00
PhabricatorAccessLog.php Fail quietly when failing to write access log 2013-05-09 16:08:26 -07:00
PhabricatorEditor.php Use ManiphestTaskQuery in nearly all interfaces 2013-09-25 13:44:14 -07:00