mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
ee9fac5c8f
Summary: Change all instances of `id(new DifferentialRevision())->load($id)` for `DifferentialRevisionQuery` where reviewers are loaded. Also make sure that the new reviewer status is being loaded so that all calls to `getReviewers` can be removed in the near future. Test Plan: Use all three controllers with several revisions and check they still work in sane way Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1279 Differential Revision: https://secure.phabricator.com/D6466
80 lines
2.1 KiB
PHP
80 lines
2.1 KiB
PHP
<?php
|
|
|
|
final class DifferentialSubscribeController extends DifferentialController {
|
|
|
|
private $id;
|
|
private $action;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = $data['id'];
|
|
$this->action = $data['action'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$revision = id(new DifferentialRevisionQuery())
|
|
->withIDs(array($this->id))
|
|
->setViewer($request->getUser())
|
|
->needRelationships(true)
|
|
->needReviewerStatus(true)
|
|
->executeOne();
|
|
if (!$revision) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
if (!$request->isFormPost()) {
|
|
$dialog = new AphrontDialogView();
|
|
|
|
switch ($this->action) {
|
|
case 'add':
|
|
$button = pht('Subscribe');
|
|
$title = pht('Subscribe to Revision');
|
|
$prompt = pht('Really subscribe to this revision?');
|
|
break;
|
|
case 'rem':
|
|
$button = pht('Unsubscribe');
|
|
$title = pht('Unsubscribe from Revision');
|
|
$prompt = pht('Really unsubscribe from this revision? Herald will '.
|
|
'not resubscribe you to a revision you unsubscribe '.
|
|
'from.');
|
|
break;
|
|
default:
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$dialog
|
|
->setUser($user)
|
|
->setTitle($title)
|
|
->appendChild(phutil_tag('p', array(), $prompt))
|
|
->setSubmitURI($request->getRequestURI())
|
|
->addSubmitButton($button)
|
|
->addCancelButton('/D'.$revision->getID());
|
|
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
|
|
$phid = $user->getPHID();
|
|
|
|
switch ($this->action) {
|
|
case 'add':
|
|
DifferentialRevisionEditor::addCCAndUpdateRevision(
|
|
$revision,
|
|
$phid,
|
|
$user);
|
|
break;
|
|
case 'rem':
|
|
DifferentialRevisionEditor::removeCCAndUpdateRevision(
|
|
$revision,
|
|
$phid,
|
|
$user);
|
|
break;
|
|
default:
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
return id(new AphrontRedirectResponse())->setURI('/D'.$revision->getID());
|
|
}
|
|
}
|