1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/config
epriestley cff043a800 Validate timezones
Summary:
Add validation for timezones, since date_default_timezone_set() returns a usable error code.

Note that we could also list all the timezones using timezone_identifiers_list(), but the list is enormous (many hundreds of entries) and impossible to use (~160 entries in "America" alone). I listed the likely US values as examples but left it as a string input text field.

Test Plan: Tried to save an invalid setting. Saved a valid setting.

Reviewers: codeblock, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2255

Differential Revision: https://secure.phabricator.com/D4318
2013-01-02 14:02:22 -08:00
..
application Begin moving Phabricator configuration into PHP 2012-12-30 15:36:06 -08:00
check Allow configuration to be explicitly validated, including validation of complex attributes 2013-01-01 18:15:03 -08:00
controller Allow configuration to be explicitly validated, including validation of complex attributes 2013-01-01 18:15:03 -08:00
editor Allow configuration to be explicitly validated, including validation of complex attributes 2013-01-01 18:15:03 -08:00
exception Allow configuration to be explicitly validated, including validation of complex attributes 2013-01-01 18:15:03 -08:00
issue Detect and raise setup warnings from within Phabricator 2012-12-30 06:37:49 -08:00
option Validate timezones 2013-01-02 14:02:22 -08:00
query Use transactions to show edit history for Configuration 2013-01-01 18:14:41 -08:00
storage Use transactions to show edit history for Configuration 2013-01-01 18:14:41 -08:00
view Improve resolution process for nonfatal setup issues 2012-12-30 17:04:38 -08:00