1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 01:12:41 +01:00
phorge-phorge/src/infrastructure/customfield
epriestley 1b192f746a Improve performance when constructing custom fields for objects
Summary:
Ref T11404. This improves things by about 10%:

  - Use `PhutilClassMapQuery`, which has slightly better caching.
  - Do a little less work to generate pretty error messages.
  - Make the "disabled" code a little faster (and sort of clearer, too?) by doing less fancy stuff.

These are pretty minor adjustments and not the sort of optimizations I'd make normally, but this code gets called ~100x (once per revision) and generates ~10 fields normally, so even small savings can amount to something.

(I also want to try to make `arc` faster in the next update, and improving Conduit performance helps with that.)

Test Plan: Ran `differential.revision.search`, saw cost drop from ~195ms to ~170ms locally.

Reviewers: yelirekim, chad

Reviewed By: chad

Maniphest Tasks: T11404

Differential Revision: https://secure.phabricator.com/D16355
2016-07-31 11:25:58 -07:00
..
config [Redesign] Remove remaining barColor callsites 2015-05-28 15:17:34 -07:00
datasource Support "Select" custom fields in Herald rules 2015-07-16 14:12:54 -07:00
editor Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
engineextension Improve Conduit performance for custom fields 2016-07-31 11:15:58 -07:00
exception Mark some strings for translation 2015-06-09 23:06:52 +10:00
field Improve performance when constructing custom fields for objects 2016-07-31 11:25:58 -07:00
herald Add "does not match regexp" to Herald 2016-02-11 15:29:38 -08:00
interface Further simplify PhabricatorCustomFieldInterface 2013-08-14 12:34:09 -07:00
parser Prevent "commit message magic words" parser from exploding on "reverts aaaa.....aaz" 2015-08-26 09:35:23 -07:00
query Improve Conduit performance for custom fields 2016-07-31 11:15:58 -07:00
standard Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
storage Improve Conduit performance for custom fields 2016-07-31 11:15:58 -07:00