1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/js/application/projects
epriestley d02beaf816 Make reloading workboards with "R" respect workboard ordering
Summary:
Depends on D20653. Ref T4900. Pass ordering details to the reload endpoint so it can give the client accurate ordering/header information in the response.

The removed comment mentions this, but here's why this is a difficult mess:

  - In window A, view a board with "Group by: Owner" and no tasks owned by "Alice". Since "Alice" owns no tasks, this means the columns do not have an "Assigned to: Alice" header!
  - In window B, edit task T and assign it to Alice.
  - In window A, press "R".

Window A now not only needs to update to properly reflect the state of task T, it actually needs to draw a new "Assigned to: Alice" header in every column.

Fortunately, the "group by" code anticipates this being a big mess, is fairly careful about handling it, and the client can handle this state change and the actual code change here isn't too involved. This is just causing a lot of not-very-obvious indirect effects in the pipeline to handle these situations that need complex redraws.

Test Plan:
  - After making various normal edits/creates/moves in window A, pressed "R" in window B. Saw ordering reflected correctly after sync.
  - Went through the whole "Group by: Owner" + assign to unrepresented owner flow above. After pressing "R", saw "Assigned to: Alice" appear on the board.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T4900

Differential Revision: https://secure.phabricator.com/D20654
2019-07-17 13:17:00 -07:00
..
behavior-project-boards.js Make pressing "R" on your keyboard reload the card state on workboards 2019-07-17 13:11:26 -07:00
behavior-project-create.js Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
behavior-reorder-columns.js Allow the workboard backlog column to be reordered 2014-08-08 15:50:36 -07:00
WorkboardBoard.js Make reloading workboards with "R" respect workboard ordering 2019-07-17 13:17:00 -07:00
WorkboardCard.js Modularize workboard column orders 2019-03-12 13:07:50 -07:00
WorkboardCardTemplate.js When updating a workboard with "R", send the client visible set with version numbers 2019-07-17 13:16:03 -07:00
WorkboardColumn.js When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip 2019-03-25 14:02:10 -07:00
WorkboardController.js Make pressing "R" on your keyboard reload the card state on workboards 2019-07-17 13:11:26 -07:00
WorkboardDropEffect.js When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip 2019-03-25 14:02:10 -07:00
WorkboardHeader.js Modularize workboard column orders 2019-03-12 13:07:50 -07:00
WorkboardHeaderTemplate.js Preview the effects of a drag-and-drop operation on workboards 2019-03-25 13:22:56 -07:00
WorkboardOrderTemplate.js Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors 2019-03-12 13:46:49 -07:00