1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/view/page
epriestley ca6b9f66e1 Replace "search scope" with selectable default behavior
Summary:
Fixes T4365. See discussion in D8123.

This implements the most conservative solution of approaches discussed in D8123. Basically:

  - When you search in primary search, we overwrite "query" in your default (topmost) search filter, and execute that.

This doesn't implement any of the other "sticky" stuff, where the query sticks around. Maybe we'll do that eventually, but it gets messy and could be confusing. Practically, this addresses the major use case in the wild, which is to make the menu bar search mean "Open Tasks" by default.

This also removes the old, obsolete "search scope" stuff. A long time ago, searching from within Maniphest would search tasks, etc., but this was pretty weird and confusing and is no longer used, and no one complained when we got rid of it.

Test Plan: Dragged "Open Tasks" to my top search, searched for "asdf", got "asdf in open tasks" results.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: bigo, aran

Maniphest Tasks: T4365

Differential Revision: https://secure.phabricator.com/D8135
2014-02-03 14:29:49 -08:00
..
menu Replace "search scope" with selectable default behavior 2014-02-03 14:29:49 -08:00
AphrontPageView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontRequestFailureView.php Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545. 2013-11-09 10:48:19 -08:00
PhabricatorBarePageView.php Properly escape inline <script> 2013-04-20 17:55:47 -07:00
PhabricatorStandardPageView.php Replace "search scope" with selectable default behavior 2014-02-03 14:29:49 -08:00