epriestley d1225e782b Don't try to load user profile images in PhabricatorPeopleQuery if no users have any ... Summary: Fixes T3810. In PhabricatorPeopleQuery, we issue an unnecessary query like this: SELECT f.* FROM file f WHERE (f.phid IN ('')) ORDER BY f.id DESC ...if we're loading a user without a profile picture. Filter the file PHIDs before loading them to prevent this. This doesn't change anything, but saves us a spurious/silly query. Also makes `PhabricatorPeopleProfileController` use `needProfileImage()`, moving us closer to getting rid of `loadProfileImageURI()` eventually. Test Plan: Looked at profiles of users with and without profile pictures. Checked query log in DarkConsole. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3810 Differential Revision: https://secure.phabricator.com/D6913		2013-09-08 09:43:27 -07:00
..
aphront	Fix an issue with darkconsole.always-on and logged-out users	2013-09-05 11:16:32 -07:00
applications	Don't try to load user profile images in PhabricatorPeopleQuery if no users have any	2013-09-08 09:43:27 -07:00
docs	Clean up some more Diviner stuff	2013-09-08 09:16:55 -07:00
extensions	Add src/extensions/ to Phabricator	2013-08-14 15:38:06 -07:00
infrastructure	Clean up some more Diviner stuff	2013-09-08 09:16:55 -07:00
view	Move Workboards to PHUI	2013-09-06 14:06:12 -07:00
__celerity_resource_map__.php	Clean up some more Diviner stuff	2013-09-08 09:16:55 -07:00
__phutil_library_init__.php	Delete license headers from files	2012-11-05 11:16:51 -08:00
__phutil_library_map__.php	Move Workboards to PHUI	2013-09-06 14:06:12 -07:00