1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/repository
epriestley d8550c114d Promote instance identity to the upstream and pass it to commit hooks
Summary:
Fixes T7019. In a cluster environment, pushes currently fail because the commit hook can't identify the instance.

For web processes, the hostname identifies the instance -- but we don't have a hostname in the hook.

For CLI processes, the environment identifies the instance -- but we don't have an environment in the hook under SVN.

Promote the instance identifier into the upstream and pack/unpack it explicitly for hooks. This is probably not useful for anyone but us, but the amount of special-purpose code we're introducing is very small.

I poked at trying to do this in a more general way, but:

  - We MUST know this BEFORE we run code, so the normal subclassing stuff is useless.
  - I couldn't come up with any other parameter which might ever be useful to pass in.

Test Plan: Used `git push` to push code through proxied HTTP, got a clean push.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7019

Differential Revision: https://secure.phabricator.com/D11495
2015-01-27 14:51:48 -08:00
..
application Add FontIcon bridge to AppIcons 2015-01-24 23:43:01 -08:00
conduit Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
constants Build an early multi-step repository create form 2013-07-14 07:37:17 -07:00
controller Modernize "arcanist project" datasource 2014-07-10 16:21:10 -07:00
customfield Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
daemon Fix the visibility of PhutilDaemon::run methods 2015-01-16 06:59:29 +11:00
data Allow Git and Mercurial repositories to be cloned with names in the URI 2014-01-30 11:42:25 -08:00
editor Modernize remaining edge types 2015-01-03 10:58:20 +11:00
engine Promote instance identity to the upstream and pass it to commit hooks 2015-01-27 14:51:48 -08:00
graphcache Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
mail Allow users to receive email about pushes via Herald 2014-03-26 13:51:15 -07:00
management Fix visibility of PhutilArgumentWorkflow::didConstruct methods 2015-01-16 07:42:07 +11:00
phid Fix some linter violations 2015-01-03 09:11:41 +11:00
query Fix method visibility for PhabricatorPolicyAwareQuery subclasses 2015-01-14 07:01:16 +11:00
response Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
search Diffusion - make projects work properly with commits 2014-11-19 14:43:59 -08:00
storage In Diffusion, split service URI resolution from conduit client construction 2015-01-27 14:50:38 -08:00
worker Remove 'initFromConduit' option from Diffusion 2015-01-23 13:31:45 -08:00
PhabricatorRepositoryConfigOptions.php Remove @group annotations 2014-07-10 08:12:48 +10:00