1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/diffusion/data
epriestley 7cbbe2ccf7 When users browse to a submodule path in Diffusion explicitly, don't fatal
Summary: Ref T13030. See PHI254. This behavior could be cleaner than I've made it, but it fixes the "this is totally broken" issue, replacing a fatal/exception with an informative (just not terribly useful) page.

Test Plan:
  - Added a submodule to a repository.
  - In Diffusion, clicked some other file next to the submodule, then edited the URI to the submodule path instead.
    - Before patch: fatal.
    - After patch: relatively useful message about this being a submodule.

Note that it's normally hard to hit this URI directly. In the browse view, submodules are marked up as directories and linked to a separate submodule resolution flow.

{F5321524}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13030

Differential Revision: https://secure.phabricator.com/D18831
2017-12-18 09:18:22 -08:00
..
__tests__ Fix text lint issues 2015-02-12 07:00:13 +11:00
DiffusionBrowseResultSet.php When users browse to a submodule path in Diffusion explicitly, don't fatal 2017-12-18 09:18:22 -08:00
DiffusionCommitHash.php Diffusion - fix another commit importing case. 2014-10-27 12:19:07 -07:00
DiffusionCommitRef.php Parse and display commit authorship date in Git in Diffusion 2016-01-11 09:32:37 -08:00
DiffusionGitBranch.php Extend from Phobject 2015-06-15 18:02:27 +10:00
DiffusionLocalRepositoryFilter.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
DiffusionPathChange.php Fix an ancient ad-hoc string truncation 2016-06-13 10:16:25 -07:00
DiffusionRepositoryPath.php Extend from Phobject 2015-06-15 18:02:27 +10:00
DiffusionRepositoryRef.php Don't track "phabricator/" staging area tags 2016-06-16 11:22:02 -07:00
DiffusionRepositoryTag.php Extend from Phobject 2015-06-15 18:02:27 +10:00