1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 18:52:42 +01:00
phorge-phorge/src/applications/phid/query
epriestley 3d52f07ee7 Make restricted objects in commit messages work more consistently with the web UI
Summary:
Fixes T11344. In the web UI, if a field like "Subscribers" on an object (like a task) contains values you don't have permission to see, you see tokens for them (like "Restricted Project") but not their names.

Make commit messages work the same way: you see the PHID, and can remove it or leave it there, but can't see the underlying name.

(We have to render an actual PHID rather than just "Restricted Thing" because we have to be able to figure out what edit the user is actually trying to make.)

Test Plan: Interacted with a revision via the CLI that had project reviewers I couldn't see.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11344

Differential Revision: https://secure.phabricator.com/D17124
2017-01-01 09:56:47 -08:00
..
__tests__ Allow blocking reviewers to be added via the CLI 2016-05-17 10:56:29 -07:00
PhabricatorHandleQuery.php Fix infinite loop in renderAccessDenied() 2015-06-30 11:42:31 -07:00
PhabricatorObjectListQuery.php Make restricted objects in commit messages work more consistently with the web UI 2017-01-01 09:56:47 -08:00
PhabricatorObjectQuery.php Use PhabricatorCachedClassMapQuery when querying object PHID types 2016-12-06 09:10:29 -08:00