1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00
phorge-phorge/src
epriestley d1fb2f7fb9 Make diffusion.filecontentquery return file PHIDs instead of raw content
Summary:
Fixes T9319. Proxied requests (e.g., in the cluster) for binary files (like images) currently fail because we can not return binary data over Conduit in JSON.

Although Conduit will eventually support binary-safe encodings, a cleaner approach to this is just to return a `filePHID` instead of the raw content. This is generally faster and more flexible, and gives us more opportunities to add caching later.

After making the call, the client pulls the file data separately.

We also no longer need to return a complex data structure because we don't do blame over this call any longer.

Test Plan:
  - Viewed images in Diffusion.
  - Viewed READMEs in Diffusion.
  - Used `bin/differential attach-commit rX Dy` to hit attach pathway.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9319

Differential Revision: https://secure.phabricator.com/D14970
2016-01-08 09:29:16 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Strip "Transfer-Encoding" headers from proxied HTTP responses 2016-01-07 16:33:09 -08:00
applications Make diffusion.filecontentquery return file PHIDs instead of raw content 2016-01-08 09:29:16 -08:00
docs Document that hosted repositories should be backed up 2016-01-05 14:03:20 -08:00
extensions
infrastructure Make queries for Project "X" mean "X, or any subproject of X" 2015-12-29 10:41:13 -08:00
view Improve Diffusion browse performance for large files 2016-01-06 09:24:35 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Make diffusion.filecontentquery return file PHIDs instead of raw content 2016-01-08 09:29:16 -08:00