1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-03 18:38:27 +01:00
phorge-phorge/src/infrastructure/diff
epriestley d30c3a961c Make the client authoritative for "Cancel" actions
Summary:
Ref T13559. When the user clicks the "Cancel" button, we sometimes take it to mean "delete" (when the comment is empty).

Both the client and server make a decision about this, and they may not agree, which causes the client to fall out of sync.

Make the client responsible for deciding whether it wants to interpret a click on the "Cancel" button as a "revert" or a "delete".

Test Plan: Cancelled empty and nonempty comments, etc. See followup changes.

Maniphest Tasks: T13559

Differential Revision: https://secure.phabricator.com/D21649
2021-03-29 09:00:25 -07:00
..
__tests__ Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on 2019-02-19 10:55:10 -08:00
engine Correct an apparent off-by-one error when adjusting inlines across revision changes 2020-08-05 13:12:53 -07:00
inline Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
interface Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
prose Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit 2020-07-23 07:46:15 -07:00
query Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
view Set an explicit height when drawing the dependent revision graph 2020-10-16 14:10:36 -07:00
viewstate Fix an issue where non-ID changeset state keys were used as changeset IDs 2020-05-04 16:05:05 -07:00
PhabricatorChangesetResponse.php Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion 2020-04-19 08:59:09 -07:00
PhabricatorDifferenceEngine.php Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
PhabricatorDiffScopeEngine.php Make very minor generality improvements to the scope selector 2019-04-30 06:52:29 -07:00
PhabricatorInlineCommentController.php Make the client authoritative for "Cancel" actions 2021-03-29 09:00:25 -07:00