mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
63 lines
1.5 KiB
PHP
63 lines
1.5 KiB
PHP
<?php
|
|
|
|
final class DifferentialCloseConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.close';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Close a Differential revision.');
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
'revisionID' => 'required int',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'void';
|
|
}
|
|
|
|
protected function defineErrorTypes() {
|
|
return array(
|
|
'ERR_NOT_FOUND' => 'Revision was not found.',
|
|
);
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$viewer = $request->getUser();
|
|
$id = $request->getValue('revisionID');
|
|
|
|
$revision = id(new DifferentialRevisionQuery())
|
|
->withIDs(array($id))
|
|
->setViewer($viewer)
|
|
->needReviewerStatus(true)
|
|
->executeOne();
|
|
if (!$revision) {
|
|
throw new ConduitException('ERR_NOT_FOUND');
|
|
}
|
|
|
|
$xactions = array();
|
|
$xactions[] = id(new DifferentialTransaction())
|
|
->setTransactionType(DifferentialTransaction::TYPE_ACTION)
|
|
->setNewValue(DifferentialAction::ACTION_CLOSE);
|
|
|
|
$content_source = PhabricatorContentSource::newForSource(
|
|
PhabricatorContentSource::SOURCE_CONDUIT,
|
|
array());
|
|
|
|
$editor = id(new DifferentialTransactionEditor())
|
|
->setActor($viewer)
|
|
->setContentSourceFromConduitRequest($request)
|
|
->setContinueOnMissingFields(true)
|
|
->setContinueOnNoEffect(true);
|
|
|
|
$editor->applyTransactions($revision, $xactions);
|
|
|
|
return;
|
|
}
|
|
|
|
}
|