mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
79 lines
2.1 KiB
PHP
79 lines
2.1 KiB
PHP
<?php
|
|
|
|
final class DifferentialUpdateRevisionConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.updaterevision';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Update a Differential revision.');
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
'id' => 'required revisionid',
|
|
'diffid' => 'required diffid',
|
|
'fields' => 'required dict',
|
|
'message' => 'required string',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'nonempty dict';
|
|
}
|
|
|
|
protected function defineErrorTypes() {
|
|
return array(
|
|
'ERR_BAD_DIFF' => 'Bad diff ID.',
|
|
'ERR_BAD_REVISION' => 'Bad revision ID.',
|
|
'ERR_WRONG_USER' => 'You are not the author of this revision.',
|
|
'ERR_CLOSED' => 'This revision has already been closed.',
|
|
);
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$viewer = $request->getUser();
|
|
|
|
$diff = id(new DifferentialDiffQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($request->getValue('diffid')))
|
|
->executeOne();
|
|
if (!$diff) {
|
|
throw new ConduitException('ERR_BAD_DIFF');
|
|
}
|
|
|
|
$revision = id(new DifferentialRevisionQuery())
|
|
->setViewer($request->getUser())
|
|
->withIDs(array($request->getValue('id')))
|
|
->needReviewerStatus(true)
|
|
->needActiveDiffs(true)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->executeOne();
|
|
if (!$revision) {
|
|
throw new ConduitException('ERR_BAD_REVISION');
|
|
}
|
|
|
|
if ($revision->getStatus() == ArcanistDifferentialRevisionStatus::CLOSED) {
|
|
throw new ConduitException('ERR_CLOSED');
|
|
}
|
|
|
|
$this->applyFieldEdit(
|
|
$request,
|
|
$revision,
|
|
$diff,
|
|
$request->getValue('fields', array()),
|
|
$request->getValue('message'));
|
|
|
|
return array(
|
|
'revisionid' => $revision->getID(),
|
|
'uri' => PhabricatorEnv::getURI('/D'.$revision->getID()),
|
|
);
|
|
}
|
|
|
|
}
|