1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/differential
epriestley d38e89ef6b Fix several issues with application interactions while importing commits
Summary:
  - Fixes T5851. Currently, if a commit has `Fixes T123`, we generate an email with just that before generating the commit email. Don't send/publish transactions about a commit before it imports (this is a tiny bit hacky, but well-contained and I don't think it causes any problems).
  - Fixes T4864. Currently, we try to parse Differential information even if Differential is not installed. Instead, do this only if Differential is installed.
  - Fixes T5771. Currently, if we can't figure out who the committer/author of a commit is, we don't publish a `Fixes T123` transaction. Instead, fall back to acting as "Diffusion" if we can't find a better actor. Most of this diff expands the role of application actors. The existing application actors (Herald and Harbormaster) seem to be working well.

Test Plan:
  - Pushed a commit with `Fixes T123` and verified it did not generate email directly. (The task half of the transaction still does, correctly.)
  - Uninstalled Differential and pushed a commit, got a clean import instead of an exception.
  - Commented out author/committer PHIDs and pushed stuff, saw a "Diffusion" actor.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5771, T4864, T5851

Differential Revision: https://secure.phabricator.com/D10221
2014-08-11 12:08:24 -07:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Rename policy capabilities 2014-07-25 08:20:39 +10:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
config Remove @group annotations 2014-07-10 08:12:48 +10:00
constants Add CCs -> Add Subscribers 2014-06-03 15:53:53 -07:00
controller Rename policy capabilities 2014-07-25 08:20:39 +10:00
customfield Spell "dependendency" less incorrecter 2014-07-30 12:59:28 -07:00
doorkeeper Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
edge Modernize task/revision edges and write inverse transactions 2014-07-17 15:41:08 -07:00
editor Fix several issues with application interactions while importing commits 2014-08-11 12:08:24 -07:00
event Modernize task/revision edges and write inverse transactions 2014-07-17 15:41:08 -07:00
exception Clean up various pieces of dead/obsolete Differential code 2014-03-11 13:02:19 -07:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Rename policy capabilities 2014-07-25 08:20:39 +10:00
lipsum Use DifferentialRevisionEditor in lipsum 2014-03-11 13:02:00 -07:00
mail Revert attempt to fix mail in differential 2014-07-31 14:54:43 -07:00
management Allow modern hunks to be stored deflated 2014-06-03 18:01:24 -07:00
parser Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Allow searching diffs by more status options 2014-07-30 13:55:05 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Utilize PhutilMethodNotImplementedException 2014-07-22 01:47:00 +10:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
view Modernize "user or project" typeahead datasources 2014-07-17 15:45:07 -07:00
DifferentialGetWorkingCopy.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00