1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 04:02:43 +01:00
phorge-phorge/src/aphront/console
epriestley d3e700ce19 Further mitigate BREACH by reducing reflectiveness
Summary:
Ref T3684. The URI itself is reflected in a few places. It is generally not dangerous because we only let you add random stuff to the end of it for one or two controllers (e.g., the file download controller lets you add "/whatever.jpg"), but:

  - Remove it entirely in the main request, since it serves no purpose.
  - Remove query parameters in Ajax requests. These are available in DarkConsole proper.

Also mask a few things in the "Request" tab; I've never used these fields when debugging or during support, and they leak quasi-sensitive information that could get screenshotted or over-the-shoulder'd.

I didn't mitgate `__metablock__` because I think the threat is so close to 0 that it's not worthwhile.

Test Plan: Used Darkconsole, examined Requests tab.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3684

Differential Revision: https://secure.phabricator.com/D6699
2013-08-07 16:09:25 -07:00
..
plugin Further mitigate BREACH by reducing reflectiveness 2013-08-07 16:09:25 -07:00
DarkConsoleController.php Created a preference pane for DarkConsole, instead of link 2013-01-19 17:42:54 -08:00
DarkConsoleCore.php Fix more JavelinView example stuff 2013-07-16 13:46:49 -07:00
DarkConsoleDataController.php Display bullet next to request with errors in DarkConsole. 2013-04-25 18:30:13 -07:00