mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-29 00:40:57 +01:00
da40f80741
Summary: Ref T13217. This method is slightly tricky: - We can't safely return a string: return an array instead. - It no longer makes sense to accept glue. All callers use `', '` as glue anyway, so hard-code that. Then convert all callsites. Test Plan: Browsed around, saw fewer "unsafe" errors in error log. Reviewers: amckinley Reviewed By: amckinley Subscribers: yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13217 Differential Revision: https://secure.phabricator.com/D19784
47 lines
1,007 B
PHP
47 lines
1,007 B
PHP
<?php
|
|
|
|
$diff_table = new DifferentialDiff();
|
|
$conn_w = $diff_table->establishConnection('w');
|
|
|
|
$size = 1000;
|
|
|
|
$row_iter = id(new LiskMigrationIterator($diff_table))->setPageSize($size);
|
|
$chunk_iter = new PhutilChunkedIterator($row_iter, $size);
|
|
|
|
foreach ($chunk_iter as $chunk) {
|
|
$sql = array();
|
|
|
|
foreach ($chunk as $diff) {
|
|
$id = $diff->getID();
|
|
echo pht('Migrating diff ID %d...', $id)."\n";
|
|
|
|
$phid = $diff->getPHID();
|
|
if (strlen($phid)) {
|
|
continue;
|
|
}
|
|
|
|
$type_diff = DifferentialDiffPHIDType::TYPECONST;
|
|
$new_phid = PhabricatorPHID::generateNewPHID($type_diff);
|
|
|
|
$sql[] = qsprintf(
|
|
$conn_w,
|
|
'(%d, %s)',
|
|
$id,
|
|
$new_phid);
|
|
}
|
|
|
|
if (!$sql) {
|
|
continue;
|
|
}
|
|
|
|
foreach (PhabricatorLiskDAO::chunkSQL($sql) as $sql_chunk) {
|
|
queryfx(
|
|
$conn_w,
|
|
'INSERT IGNORE INTO %T (id, phid) VALUES %LQ
|
|
ON DUPLICATE KEY UPDATE phid = VALUES(phid)',
|
|
$diff_table->getTableName(),
|
|
$sql_chunk);
|
|
}
|
|
}
|
|
|
|
echo pht('Done.')."\n";
|