1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
phorge-phorge/webroot/rsrc/js/application/differential
epriestley 869f24bf33 Fix reticle for diff-of-diffs
Summary:
The older logic was incorrect:

  - It chose `change.left` for `data.on_right` being true.
  - 'O' and 'N' mean 'old' and 'new', not 'left' and 'right'. In diff-of-diffs, both sides are 'N'.

So, select the changeset ID correctly (pick the right side one for on_right), and select the new file prefix correctly (N for new, O for old).

Test Plan: Waved my mouse over some inline comments in a diff-of-diffs, got reasonable-looking reticles.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1076

Differential Revision: https://secure.phabricator.com/D2138
2012-04-07 10:39:41 -07:00
..
behavior-accept-with-errors.js Added a big warning if reviewer is about to accept a diff with lint or unit 2011-06-13 11:49:31 -07:00
behavior-add-reviewers-and-ccs.js Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code 2012-03-09 15:46:39 -08:00
behavior-comment-jump.js Added 'Next' and 'Previous' links to differential 2011-05-11 14:46:00 -07:00
behavior-comment-preview.js Improve inline comment previews 2012-03-28 10:11:41 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-dropdown-menus.js Add "View Options" dropdown to Differential / Audit 2012-03-19 19:57:41 -07:00
behavior-edit-inline-comments.js Fix reticle for diff-of-diffs 2012-04-07 10:39:41 -07:00
behavior-keyboard-nav.js Improve inline comment previews 2012-03-28 10:11:41 -07:00
behavior-populate.js Show a tooltip about code coverage 2012-03-12 20:04:12 -07:00
behavior-show-all-comments.js Go to correct position after revealing comments 2012-02-26 13:13:51 -08:00
behavior-show-more.js Show a tooltip about code coverage 2012-03-12 20:04:12 -07:00
DifferentialInlineCommentEditor.js Don't provide Undo for empty text in Differential inline comment 2012-02-29 23:44:42 -08:00