mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 09:12:41 +01:00
22551d106d
Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107. Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6107 Differential Revision: https://secure.phabricator.com/D10843 |
||
|---|---|---|
| .. | ||
| behavior-add-reviewers-and-ccs.js | ||
| behavior-comment-jump.js | ||
| behavior-comment-preview.js | ||
| behavior-diff-radios.js | ||
| behavior-dropdown-menus.js | ||
| behavior-edit-inline-comments.js | ||
| behavior-keyboard-nav.js | ||
| behavior-populate.js | ||
| behavior-show-all-comments.js | ||
| behavior-show-field-details.js | ||
| behavior-show-more.js | ||
| behavior-toggle-files.js | ||
| behavior-user-select.js | ||
| ChangesetViewManager.js | ||
| DifferentialInlineCommentEditor.js | ||