1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-14 16:51:08 +01:00
phorge-phorge/src/applications/search
epriestley d67b7f0f47 Correct column mutations for old versions of MySQL
Summary:
Ref T1191. Although I fixed some of the mutations earlier (in D10598), I missed the column mutations under old versions of MySQL. In particular, this isn't valid:

  - `ALTER TABLE ... MODIFY columnName VARCHAR(64) COLLATE binary`

Issue the permitted version of this instead, which is:

  - `ALTER TABLE ... MODIFY columnName VARBINARY(64)`

Also fixed an issue where a clean schema had the wrong nullability for a column in the draft table. Force it to the expected nullability.

The other trick here is around the one column with a FULLTEXT index on it, which needs a little massaging.

Test Plan:
  - Forced my local install to return `false` for utf8mb4 support.
  - Did a clean adjust into `binary` columns.
  - Poked around, added emoji to things.
  - Reverted the fake check and did a clean adjust into `utf8mb4` columns.
  - Emoji survived.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: fabe, epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10627
2014-10-02 14:44:22 -07:00
..
application Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
config Make it possible to configure Elasticsearch index name 2014-07-10 18:41:05 -07:00
constants Remove @group annotations 2014-07-10 08:12:48 +10:00
controller Maniphest - upgrade merging to real transactions 2014-09-08 14:17:35 -07:00
engine Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
index Use ApplicationTransactions when indexing commit/audit comments 2014-07-28 15:02:18 -07:00
interface Provide PhabricatorSavedQuery to renderResultsList() 2013-07-03 05:46:04 -07:00
management Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
query Rename PHIDType classes 2014-07-24 08:05:46 +10:00
selector Provide a setup warning about using the default MySQL stopword file 2014-08-13 15:34:09 -07:00
storage Correct column mutations for old versions of MySQL 2014-10-02 14:44:22 -07:00
typeahead Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
view Write search bolding in a way which is certainly HTML-safe 2014-04-26 12:44:16 -07:00
worker Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00