mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 16:22:43 +01:00
0ac1be7094
Summary: Depends on D7519. This implements support for build logs in Harbormaster. This includes support for appending to a log from the "Run Remote Command" build step. It also adds the ability to cancel builds. Currently the build view page doesn't update the logs live; I'm sure this can be achieved with Javelin, but I don't have enough experience with Javelin to actually make it poll from updates to content in the background. {F79151} {F79153} {F79150} {F79152} Test Plan: Tested this by setting up SSH on a Windows machine and using a Remote Command configured with: ``` C:\Windows\system32\cmd.exe /C cd C:\Build && mkdir Build_${timestamp} && cd Build_${timestamp} && git clone --recursive https://github.com/hach-que/Tychaia.git && cd Tychaia && Protobuild.exe && C:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe Tychaia.Windows.sln ``` and observed the output of the build stream from the Windows machine into Phabricator. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley CC: Korvin, epriestley, aran Maniphest Tasks: T1049 Differential Revision: https://secure.phabricator.com/D7521
161 lines
4.7 KiB
PHP
161 lines
4.7 KiB
PHP
<?php
|
|
|
|
final class HarbormasterStepEditController
|
|
extends HarbormasterController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = idx($data, 'id');
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
$this->requireApplicationCapability(
|
|
HarbormasterCapabilityManagePlans::CAPABILITY);
|
|
|
|
$step = id(new HarbormasterBuildStepQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($this->id))
|
|
->executeOne();
|
|
if (!$step) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$plan = id(new HarbormasterBuildPlanQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(array($step->getBuildPlanPHID()))
|
|
->executeOne();
|
|
if (!$plan) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$implementation = $step->getStepImplementation();
|
|
$implementation->validateSettingDefinitions();
|
|
$settings = $implementation->getSettings();
|
|
|
|
$errors = array();
|
|
if ($request->isFormPost()) {
|
|
foreach ($implementation->getSettingDefinitions() as $name => $opt) {
|
|
$readable_name = $this->getReadableName($name, $opt);
|
|
$value = $this->getValueFromRequest($request, $name, $opt['type']);
|
|
|
|
// TODO: This won't catch any validation issues unless the field
|
|
// is missing completely. How should we check if the user is
|
|
// required to enter an integer?
|
|
if ($value === null) {
|
|
$errors[] = $readable_name.' is not valid.';
|
|
} else {
|
|
$step->setDetail($name, $value);
|
|
}
|
|
}
|
|
|
|
if (count($errors) === 0) {
|
|
$step->save();
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI($this->getApplicationURI('plan/'.$plan->getID().'/'));
|
|
}
|
|
}
|
|
|
|
$form = id(new AphrontFormView())
|
|
->setUser($viewer);
|
|
|
|
$instructions = $implementation->getSettingRemarkupInstructions();
|
|
if ($instructions !== null) {
|
|
$form->appendRemarkupInstructions($instructions);
|
|
}
|
|
|
|
// We need to render out all of the fields for the settings that
|
|
// the implementation has.
|
|
foreach ($implementation->getSettingDefinitions() as $name => $opt) {
|
|
if ($request->isFormPost()) {
|
|
$value = $this->getValueFromRequest($request, $name, $opt['type']);
|
|
} else {
|
|
$value = $settings[$name];
|
|
}
|
|
|
|
switch ($opt['type']) {
|
|
case BuildStepImplementation::SETTING_TYPE_STRING:
|
|
case BuildStepImplementation::SETTING_TYPE_INTEGER:
|
|
$control = id(new AphrontFormTextControl())
|
|
->setLabel($this->getReadableName($name, $opt))
|
|
->setName($name)
|
|
->setValue($value);
|
|
break;
|
|
case BuildStepImplementation::SETTING_TYPE_BOOLEAN:
|
|
$control = id(new AphrontFormCheckboxControl())
|
|
->setLabel($this->getReadableName($name, $opt))
|
|
->setName($name)
|
|
->setValue($value);
|
|
break;
|
|
default:
|
|
throw new Exception("Unable to render field with unknown type.");
|
|
}
|
|
|
|
if (isset($opt['description'])) {
|
|
$control->setCaption($opt['description']);
|
|
}
|
|
|
|
$form->appendChild($control);
|
|
}
|
|
|
|
$form->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->setValue(pht('Save Step Configuration'))
|
|
->addCancelButton(
|
|
$this->getApplicationURI('plan/'.$plan->getID().'/')));
|
|
|
|
$box = id(new PHUIObjectBoxView())
|
|
->setHeaderText('Edit Step: '.$implementation->getName())
|
|
->setValidationException(null)
|
|
->setForm($form);
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$id = $plan->getID();
|
|
$crumbs->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName(pht("Plan %d", $id))
|
|
->setHref($this->getApplicationURI("plan/{$id}/")));
|
|
$crumbs->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName(pht('Edit Step')));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$box,
|
|
),
|
|
array(
|
|
'title' => $implementation->getName(),
|
|
'device' => true,
|
|
));
|
|
}
|
|
|
|
public function getReadableName($name, $opt) {
|
|
$readable_name = $name;
|
|
if (isset($opt['name'])) {
|
|
$readable_name = $opt['name'];
|
|
}
|
|
return $readable_name;
|
|
}
|
|
|
|
public function getValueFromRequest(AphrontRequest $request, $name, $type) {
|
|
switch ($type) {
|
|
case BuildStepImplementation::SETTING_TYPE_STRING:
|
|
return $request->getStr($name);
|
|
break;
|
|
case BuildStepImplementation::SETTING_TYPE_INTEGER:
|
|
return $request->getInt($name);
|
|
break;
|
|
case BuildStepImplementation::SETTING_TYPE_BOOLEAN:
|
|
return $request->getBool($name);
|
|
break;
|
|
default:
|
|
throw new Exception("Unsupported setting type '".$type."'.");
|
|
}
|
|
}
|
|
|
|
}
|