1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 21:32:43 +01:00
phorge-phorge/webroot/rsrc/js/application/differential
epriestley 7a96de10f0 Hide seen transactions by default in all modern applications
Summary:
Ref T2222. This restores the "N older comments are hidden." shield to all ApplicationTransactions applications. Roughly the rule this uses is that transactions older than your most recent comment are hidden, under the assumption that you've already read and dealt with them, since you replied afterward. Then we show your last comment to remind/contextualize you, and anything afterward. We also don't hide transactions if we'd only be hiding a handfull, and we never hide the few most recent transactions.

This might need some #design help.

Test Plan:
The tricky part here is the anchor rule, which deals with the case where you follow a link to `T123#4`, but that would normally be hidden. We simulate a click on "show all" if you hit an anchor which is hidden. Here's what it looks like in Maniphest:

{F112891}

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: chad, aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8229
2014-02-14 10:23:07 -08:00
..
behavior-accept-with-errors.js Toggle accept warnings on reload 2012-12-17 12:31:00 -08:00
behavior-add-reviewers-and-ccs.js Show add reviewer typehead when user selects resign as a reviewer. 2013-07-10 11:05:53 -07:00
behavior-comment-jump.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-comment-preview.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-dropdown-menus.js See https://github.com/facebook/phabricator/issues/262 2013-07-08 19:56:43 -07:00
behavior-edit-inline-comments.js Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00
behavior-keyboard-nav.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-populate.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-show-all-comments.js Hide seen transactions by default in all modern applications 2014-02-14 10:23:07 -08:00
behavior-show-field-details.js Further improve unit/lint rendering 2012-05-01 10:15:56 -07:00
behavior-show-more.js Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00
behavior-toggle-files.js Better JS for Differential File Collapsing Undo 2013-08-13 16:14:26 -07:00
behavior-user-select.js Enable selecting text in Differential shield and gap 2012-09-20 15:20:47 -07:00
DifferentialInlineCommentEditor.js Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00