mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 09:12:41 +01:00
4fd4ec3d27
Summary: Ref T12616. Fixes T12153. Currently, when you hide inlines, they hide completely and turn into a little bubble on the previous line. Instead, collapse them to a single line one-by-one. Narrowly, this fixes T12153. In the future, I plan to make these changes so this feature makes more sense: - Introduce global "hide everything" states (T8909) so you can completely hide stuff if you want, and this represents more of a halfway state between "nuke it" and "view it". - Make the actual rendering better, so it says "epriestley: blah blah..." instead of just "..." -- and looks less dumb. The real goal here is to introduce `DiffInline` and continue moving stuff from the tangled jungle of a million top-level behaviors to sensible smooth statefulness. Test Plan: - Hid and revealed inlines in unified and two-up modes. - These look pretty junk for now: {F4948659} Reviewers: chad Reviewed By: chad Maniphest Tasks: T12616, T12153 Differential Revision: https://secure.phabricator.com/D17861
140 lines
3.6 KiB
JavaScript
140 lines
3.6 KiB
JavaScript
/**
|
|
* @provides javelin-behavior-differential-populate
|
|
* @requires javelin-behavior
|
|
* javelin-dom
|
|
* javelin-stratcom
|
|
* phabricator-tooltip
|
|
* phabricator-diff-changeset-list
|
|
* phabricator-diff-changeset
|
|
* @javelin
|
|
*/
|
|
|
|
JX.behavior('differential-populate', function(config, statics) {
|
|
|
|
// When we perform a Quicksand navigation, deactivate the changeset lists on
|
|
// the current page and activate the changeset lists on the new page.
|
|
var onredraw = function(page_id) {
|
|
// If the current page is already active, we don't need to do anything.
|
|
if (statics.pageID === page_id) {
|
|
return;
|
|
}
|
|
|
|
var ii;
|
|
|
|
// Put the old lists to sleep.
|
|
var old_lists = get_lists(statics.pageID);
|
|
for (ii = 0; ii < old_lists.length; ii++) {
|
|
old_lists[ii].sleep();
|
|
}
|
|
statics.pageID = null;
|
|
|
|
// Awaken the new lists, if they exist.
|
|
if (statics.pages.hasOwnProperty(page_id)) {
|
|
var new_lists = get_lists(page_id);
|
|
for (ii = 0; ii < new_lists.length; ii++) {
|
|
new_lists[ii].wake();
|
|
}
|
|
|
|
statics.pageID = page_id;
|
|
}
|
|
};
|
|
|
|
// Get changeset lists on the current page.
|
|
var get_lists = function(page_id) {
|
|
if (page_id === null) {
|
|
return [];
|
|
}
|
|
|
|
return statics.pages[page_id] || [];
|
|
};
|
|
|
|
if (!statics.installed) {
|
|
statics.installed = true;
|
|
statics.pages = {};
|
|
statics.pageID = null;
|
|
|
|
JX.Stratcom.listen('quicksand-redraw', null, function(e) {
|
|
onredraw(e.getData().newResponseID);
|
|
});
|
|
}
|
|
|
|
var changeset_list = new JX.DiffChangesetList()
|
|
.setTranslations(JX.phtize(config.pht))
|
|
.setInlineURI(config.inlineURI);
|
|
|
|
// Install and activate the current page.
|
|
var page_id = JX.Quicksand.getCurrentPageID();
|
|
statics.pages[page_id] = [changeset_list];
|
|
onredraw(page_id);
|
|
|
|
|
|
|
|
for (var ii = 0; ii < config.changesetViewIDs.length; ii++) {
|
|
var id = config.changesetViewIDs[ii];
|
|
var node = JX.$(id);
|
|
var changeset = changeset_list.newChangesetForNode(node);
|
|
if (changeset.shouldAutoload()) {
|
|
changeset.setStabilize(true).load();
|
|
}
|
|
}
|
|
|
|
var highlighted = null;
|
|
var highlight_class = null;
|
|
|
|
JX.Stratcom.listen(
|
|
['mouseover', 'mouseout'],
|
|
['differential-changeset', 'tag:td'],
|
|
function(e) {
|
|
var t = e.getTarget();
|
|
|
|
// NOTE: Using className is not best practice, but the diff UI is perf
|
|
// sensitive.
|
|
if (!t.className.match(/cov|copy/)) {
|
|
return;
|
|
}
|
|
|
|
if (e.getType() == 'mouseout') {
|
|
JX.Tooltip.hide();
|
|
if (highlighted) {
|
|
JX.DOM.alterClass(highlighted, highlight_class, false);
|
|
highlighted = null;
|
|
}
|
|
} else {
|
|
highlight_class = null;
|
|
var msg;
|
|
var align = 'W';
|
|
var sibling = 'previousSibling';
|
|
var width = 120;
|
|
if (t.className.match(/cov-C/)) {
|
|
msg = 'Covered';
|
|
highlight_class = 'source-cov-C';
|
|
} else if (t.className.match(/cov-U/)) {
|
|
msg = 'Not Covered';
|
|
highlight_class = 'source-cov-U';
|
|
} else if (t.className.match(/cov-N/)) {
|
|
msg = 'Not Executable';
|
|
highlight_class = 'source-cov-N';
|
|
} else {
|
|
var match = /new-copy|new-move/.exec(t.className);
|
|
if (match) {
|
|
sibling = 'nextSibling';
|
|
width = 500;
|
|
msg = JX.Stratcom.getData(t).msg;
|
|
highlight_class = match[0];
|
|
}
|
|
}
|
|
|
|
if (msg) {
|
|
JX.Tooltip.show(t, width, align, msg);
|
|
}
|
|
|
|
if (highlight_class) {
|
|
highlighted = t[sibling];
|
|
JX.DOM.alterClass(highlighted, highlight_class, true);
|
|
}
|
|
}
|
|
|
|
});
|
|
|
|
|
|
});
|