1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
phorge-phorge/webroot/rsrc
epriestley 58b55c2fa6 Probably improve behavior around duplicate notifications
Summary:
We're sometimes getting duplicate notifications right now. I think this is because multiple windows are racing and becoming leaders.

Clean this up a little:

  - Fix the `timeoout` typo.
  - Only try to usurp once.
  - Use different usurp and expire delays, so we don't fire them at the exact same time.

Not sure if this'll work or not but it should theoretically be a little cleaner.

Test Plan:
  - Quit Safari, reopened Safari, still saw a fast reconnect to the notification server (this is the goal of usurping).
  - Did normal notification stuff like opening a chat in two windows, got notifications.
  - Hard to reproduce the race for sure, but this at least fixes the outright `timeoout` bug.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15806
2016-04-27 03:56:55 -07:00
..
css Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
externals Probably improve behavior around duplicate notifications 2016-04-27 03:56:55 -07:00
favicons Add mask-icon for Safari pinned tab 2015-11-22 13:04:06 -08:00
image Polish up timeline for PHIUTwoColumnView 2016-03-08 17:51:53 -08:00
js When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1. 2016-04-20 09:15:45 -07:00