1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-25 21:19:21 +01:00
phorge-phorge/src/applications/project/view
epriestley 4485482fd4 Fix task hovercards showing a "Not Editable" state
Summary:
Ref T13269. These cards really have three states:

  - Editable: shows a pencil icon edit button.
  - You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  - Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan:
Looked at a...

  - Editable card on workboard: edit state.
  - No permission card on workboard: no permission state.
  - Any hovercard: "not editable, this is a hovercard" state.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13269

Differential Revision: https://secure.phabricator.com/D20330
2019-03-26 15:56:09 -07:00
..
PhabricatorProjectCardView.php Add getDisplayName to cards and profiles 2016-02-05 13:13:48 -08:00
PhabricatorProjectListView.php Support subtypes in Projects 2019-01-30 06:17:55 -08:00
PhabricatorProjectMemberListView.php Clean up watchers and members project page 2017-05-15 15:56:14 -07:00
PhabricatorProjectUserListView.php Only show member/watcher notes on Members page in Projects 2017-05-16 07:17:18 -07:00
PhabricatorProjectWatcherListView.php Clean up watchers and members project page 2017-05-15 15:56:14 -07:00
ProjectBoardTaskCard.php Fix task hovercards showing a "Not Editable" state 2019-03-26 15:56:09 -07:00