revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-13 12:54:53 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Andre Klapper dbcc447249 Fix error in Mercurial when no offset is specified 
Summary:
When viewing the history of a Mercurial diffusion repository the server return a 500. This is
because a function call to array_slice requires the offset to be set to an integer. So when it is
not specified it can be set to 0 as a default.

The error is as follows:

```
ERROR 8192: array_slice(): Passing null to parameter #2 ($offset) of type int is deprecated at [/usr/local/www/phorge/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:167]; PHP message: arcanist(head=master, ref.master=3cb117684f4e), phorge(head=master, ref.master=4bf5c452eb28); PHP message:   #0 array_slice(array, NULL) called at [<phorge>/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:167]
```

Test Plan: The history tab should not return a 500 when not specifying an offset

Reviewers: O1 Blessed Committers, valerio.bozzolan, speck

Reviewed By: O1 Blessed Committers, valerio.bozzolan, speck

Subscribers: aklapper, speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25673
2024-12-11 12:02:14 +01:00
..
almanac Drydock and Almanac: add welcome pages 2024-06-25 09:37:01 +02:00
aphlict Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter 2024-04-17 13:11:07 +02:00
arcanist/conduit
audit Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
auth Account registration: Restrict Real Name length 2024-12-02 20:36:39 +01:00
badges Disallow awarding a badge without selecting recipient 2024-07-30 10:50:28 +02:00
base Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
cache Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
calendar Validate some user provided calendar query range dates 2024-11-26 15:12:22 +01:00
celerity Drop question mark suffix from optional PHPDoc @param types 2024-09-06 19:17:00 +02:00
conduit Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
config Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
conpherence Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
console DarkConsole: Fix "strlen(null)" but for the "tab" query parameter 2024-10-28 09:26:20 +01:00
countdown Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
daemon Remove unused parameter from PhabricatorDaemonController::buildSideNavView() call 2024-07-26 13:48:44 +02:00
dashboard Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
differential Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
diffusion Fix error in Mercurial when no offset is specified 2024-12-11 12:02:14 +01:00
diviner Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
doorkeeper Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
fact Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative return type mixed of method Iterator::key()" 2024-08-02 11:44:25 +02:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
files Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
flag Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
fund Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Fix typos in Harbormaster 2024-12-10 23:05:08 -05:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald PHPDoc: Replace "@return this" with "@return $this" 2024-09-09 15:48:09 +02:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
lipsum
macro Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
maniphest Make maniphest.gettasktransactions include metadata and title 2024-11-26 14:08:48 +01:00
meta Drop question mark suffix from optional PHPDoc @param types 2024-09-06 19:17:00 +02:00
metamta Add first unit test for mimemailparser headers 2024-12-06 13:12:54 +01:00
multimeter Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page 2023-05-29 12:35:54 +02:00
notification PHPDoc: Replace "@return this" with "@return $this" 2024-09-09 15:48:09 +02:00
nuance Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
oauthserver Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
owners Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
packages Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
passphrase Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
paste Fix PHP 8.1 "strlen(null)" exception in PhabricatorPasteLanguageTransaction.php 2024-05-02 10:28:08 +02:00
people Repository Identity "Automatically Detected User": don't trust unverified emails 2024-12-11 09:31:14 +01:00
phame Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
phid Avoid "Unknown Object (????)" for custom Select field values in Herald editor 2024-11-28 12:41:41 +01:00
phlux Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
pholio Warn in comment field if task is closed as duplicate 2024-06-23 15:29:17 +02:00
phortune Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
phpast Remove deprecated buildStandardPage* method calls 2024-05-16 08:39:08 +02:00
phrequent Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
phriction Fix missing file attachment in Phriction 2024-07-01 18:41:55 +02:00
phurl Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
policy Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
ponder Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-23 11:09:36 +02:00
project Rewrite regex for project names to be not prone to catastrophic backtracking 2024-12-05 12:40:44 -05:00
reference/src Make the Remarkup Help Page Extensible 2024-06-26 22:11:44 +02:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository Repository Identity "Automatically Detected User": don't trust unverified emails 2024-12-11 09:31:14 +01:00
search Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data 2024-12-09 12:00:03 +01:00
settings Fix implicitly nullable parameter declarations for PHP 8.4 2024-10-24 17:19:42 +02:00
slowvote Warn in comment field if task is closed as duplicate 2024-06-23 15:29:17 +02:00
spaces Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
subscriptions PHPDoc: Replace "@return this" with "@return $this" 2024-09-09 15:48:09 +02:00
support/application
system Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
tokens Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
transactions Fix a typo in documentation 2024-11-26 11:44:38 +01:00
typeahead Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
uiexample Implements copy button in clone repo modal 2024-02-15 19:38:39 +01:00
xhprof Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00