1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-23 21:18:19 +01:00
phorge-phorge/webroot/rsrc/js/application
Alan Huang dbde4b9ff2 Fix issues with Differential file toggling
Summary:
See D2714#15.

 # Give anchors an `id` equal to their `name` so JX.$ can find them.
 # Listen for `click` s on `<a>` s instead of `hashchange` s to make
   toggling a bit more correct and consistent.
 # Add a placeholder menu item when the file is unloaded. A previous
   patch by @jungejason had left the item blank in that case.
 # In fixing (1) I found another exception when clicking on ToC links.
   Since those links are `differential-load`, they try to load the file
   before jumping to it. However, loading destroys the node it's looking
   for, so if you jump to an already-loaded file JX.$ complains at you.

Test Plan: Make a giant diff. Click on links and try toggling files.

Reviewers: epriestley, vrana

Reviewed By: vrana

CC: vrana, aran, Korvin

Maniphest Tasks: T370

Differential Revision: https://secure.phabricator.com/D3185
2012-08-09 17:53:05 -07:00
..
aphlict Switch to new menubar 2012-07-30 16:09:14 -07:00
core Include symbols in main typeahead 2012-08-01 12:36:47 -07:00
countdown Remove usage of JX.defer in favor of setTimeout 2011-08-10 18:09:59 -07:00
differential Fix issues with Differential file toggling 2012-08-09 17:53:05 -07:00
diffusion Highlight lines on drag and drop in Diffusion 2012-08-05 18:56:25 -07:00
herald Allow users to add flags via Herald rules 2012-03-30 13:51:54 -07:00
maniphest Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
owners Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
phame Phame - introduce blogs 2012-07-19 09:03:10 -07:00
phortune For discussion -- Stripe integration 2012-04-04 16:09:29 -07:00
phriction Add a document preview to Phriction 2011-07-16 18:48:27 -07:00
projects Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
repository Support data-symbol-name in symbol linking 2012-08-09 15:19:02 -07:00
uiexample Add multiple notifications and notification types 2012-06-17 11:35:36 -07:00