1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
phorge-phorge/webroot
epriestley dbf1d0d721 Improve reliability of detecting small devices when loading Differential changesets
Summary: Ref T10229. Fixes T9969. We make a decision about 1up vs 2up pretty early, and sometimes the viewport size reads as larger than the device, so we incorrectly select 2up when the proper setting would be 1up.

Test Plan:
I can reproduce this by, e.g., reloading a lot on an iPhone 4s in iOS Simulator running iOS 9.2. Sometimes it picks 2-up. I added logging to show that the viewport dimension read was the issue.

After this change, it always selects 1-up (`window.screen.availWidth` is defined and sensible on the device).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9969, T10229

Differential Revision: https://secure.phabricator.com/D15135
2016-01-29 06:55:22 -08:00
..
rsrc Improve reliability of detecting small devices when loading Differential changesets 2016-01-29 06:55:22 -08:00
favicon.ico Add HiDPI favicons 2014-11-07 17:07:38 -08:00
index.php Add a "Startup" to DarkConsole 2015-08-21 14:53:29 -07:00