1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 15:22:41 +01:00
phorge-phorge/src/applications/audit
epriestley 65de9e9f5e Ignore "Auditors: author" when inferring auditors from commit messages
Summary:
Fixes T12406. When importing commits, we automatically add auditors if the message lists "Auditors: username".

If the list of auditors includes the commit author, this edit fails because you can't audit your own commits (previously, you sometimes could and/or we didn't validate).

Instead, just ignore "Auditors: author".

Test Plan:
  - Made a commit with "Auditors: epriestley".
  - Pushed it.
  - Saw the HeraldWorker get stuck with the error in T12406.
  - Applied the change; worker now succeeded.

Reviewers: chad

Reviewed By: chad

Subscribers: alexmv

Maniphest Tasks: T12406

Differential Revision: https://secure.phabricator.com/D17507
2017-03-16 13:57:51 -07:00
..
application Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
conduit Remove several pieces of audit-related code 2017-01-30 15:26:26 -08:00
constants Remove several pieces of audit-related code 2017-01-30 15:26:26 -08:00
controller Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
editor Ignore "Auditors: author" when inferring auditors from commit messages 2017-03-16 13:57:51 -07:00
mail Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
management Make "bin/audit synchronize" actually save changes 2017-01-31 12:23:49 -08:00
query Allow commits to be queried by repository using the tagged(...) typehaead function 2017-02-27 10:46:55 -08:00
storage Give Audit an informational "This commit now requires (something)..." transaction 2017-01-25 07:53:18 -08:00
view Excluded authored commits from "Ready to Audit"; handle unreachable commits better 2017-01-31 13:37:05 -08:00