1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications/metamta
epriestley a7c681b549 Don't set mail HTML bodies if there's no actual HTML body
Summary:
See <https://discourse.phabricator-community.org/t/commit-6011085b0fcd-breaks-sending-certain-email/1571>. Some mailers get upset if we `setHTMLBody(...)` with an empty string.

There's some possible argument they should be more graceful about this, but it's reasonably pretty ambiguous.

Only try to set the HTML body if we actually have a nonempty HTML body.

Test Plan:
  - Configured an "smtp" mailer.
  - Ran `echo hi | ./bin/mail send-test --to someone@somewhere.com --subject test`.
  - Before: error about empty message body.
  - After: no more message body error.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19494
2018-06-15 14:01:40 -07:00
..
action When we fail to process mail, tell the user about it 2014-04-03 18:43:18 -07:00
adapter Respect "metamta.email-body-limit" when building mail HTML bodies 2018-06-12 12:02:15 -07:00
application Support Postmark inbound mail via webhook 2018-02-08 06:25:26 -08:00
applicationpanel Separate button CSS classes 2017-06-05 20:14:34 +00:00
command Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
constants Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Configure a whitelist of remote addresses for Postmark inbound webhooks 2018-02-08 08:23:14 -08:00
edge MetaMTA - more progress towards a mail application 2015-06-23 11:37:14 -07:00
editor Use ApplicationTransactions in ApplicationEmail 2015-06-11 10:15:49 -07:00
engine Add basic support for mail "stamps" to improve client mail routing 2018-02-06 04:04:13 -08:00
engineextension Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
garbagecollector Support DestructionEngine in MetaMTAMail 2018-02-02 14:37:33 -08:00
herald Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
management Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
parser Extend from Phobject 2015-06-15 18:02:27 +10:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
receiver Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
replyhandler Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
stamp Fix a mail stamp issue with blocking reviewers 2018-02-13 17:56:21 -08:00
storage Don't set mail HTML bodies if there's no actual HTML body 2018-06-15 14:01:40 -07:00
typeahead Include owners packages in the MailableFunction datasource 2018-06-07 12:02:50 -07:00
view Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email 2018-02-16 09:55:04 -08:00
PhabricatorMetaMTAWorker.php Send permanent dameon failures to the log, even when not running in verbose mode 2017-06-08 15:26:19 -07:00