revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion/controller
History
epriestley dd2b10b8f8 Guarantee repositories have unique local paths 
Summary:
Ref T4039. Long ago these were more freely editable and there were some security concerns around creating a repository, then setting its local path to point somewhere it shouldn't.

Local paths are no longer editable so there's no real reason we need to provide a uniqueness guarantee anymore, but you could still make a mistake with `bin/repository move-paths` by accident, and it's a little cleaner to pull them out into their own column with a key.

(We still don't -- and, largely can't -- guarantee that two paths aren't //equivalent// since one might be symlinked to the other, or symlinked only on some hosts, or whatever, but the primary value here is as a sanity check that you aren't goofing things up and pointing a bunch of repositories at the same working copy by mistake.)

Test Plan:
  - Ran migrations.
  - Grepped for `local-path`.
  - Listed and moved paths with `bin/repository`.
  - Created a new repository, verified its local path populated correctly.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4039

Differential Revision: https://secure.phabricator.com/D15837
2016-05-04 16:09:52 -07:00
..
DiffusionBranchTableController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionBrowseController.php Add coverage tooltips in Diffusion file browse mode 2016-04-15 06:59:38 -07:00
DiffusionChangeController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionCommitBranchesController.php Show first 10 branches, then "More Branches" for commits on huge numbers of branches 2016-02-16 15:10:01 -08:00
DiffusionCommitController.php Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
DiffusionCommitEditController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionCommitTagsController.php Show first 10 branches, then "More Branches" for commits on huge numbers of branches 2016-02-16 15:10:01 -08:00
DiffusionController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionDiffController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionExternalController.php Fix two issues with callsign-free repositories 2016-02-26 06:13:46 -08:00
DiffusionHistoryController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionInlineCommentController.php Correctly clear draft markers when deleting an inline comment 2015-07-21 11:36:46 -07:00
DiffusionInlineCommentPreviewController.php Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00
DiffusionLastModifiedController.php Make dates/times more concise in Diffusion 2016-03-18 09:11:09 -07:00
DiffusionLintController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionMirrorDeleteController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionMirrorEditController.php Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
DiffusionPathCompleteController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathTreeController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathValidateController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPushEventViewController.php Fix an issue with PHID/handle management in push logs 2016-04-20 04:47:10 -07:00
DiffusionPushLogController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushLogListController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRefTableController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRepositoryController.php Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
DiffusionRepositoryCreateController.php Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
DiffusionRepositoryDefaultController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditActionsController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditActivateController.php Support more transactions types in RepositoryEditEngine 2016-04-17 16:27:02 -07:00
DiffusionRepositoryEditAutomationController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditBasicController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditBranchesController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditDangerousController.php Split Repository EditEngine form into smaller pages 2016-05-02 08:28:38 -07:00
DiffusionRepositoryEditDeleteController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditEncodingController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditHostingController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditMainController.php Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
DiffusionRepositoryEditproController.php Give users a modal VCS choice when creating a new repository 2016-04-29 09:20:31 -07:00
DiffusionRepositoryEditStagingController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditStorageController.php Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
DiffusionRepositoryEditSubversionController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryEditUpdateController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryListController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRepositoryManageController.php Add icons to the new repository edit nav 2016-05-03 08:01:18 -07:00
DiffusionRepositoryNewController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionRepositorySymbolsController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionRepositoryTestAutomationController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryURICredentialController.php Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
DiffusionRepositoryURIDisableController.php Flesh out more web UI actions for new URI interface 2016-04-29 17:16:15 -07:00
DiffusionRepositoryURIEditController.php Flesh out more web UI actions for new URI interface 2016-04-29 17:16:15 -07:00
DiffusionRepositoryURIViewController.php Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
DiffusionServeController.php Move all cluster locking logic to a separate class 2016-04-25 11:20:29 -07:00
DiffusionSymbolController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionTagListController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00