1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
phorge-phorge/src/applications/repository
epriestley dd2b10b8f8 Guarantee repositories have unique local paths
Summary:
Ref T4039. Long ago these were more freely editable and there were some security concerns around creating a repository, then setting its local path to point somewhere it shouldn't.

Local paths are no longer editable so there's no real reason we need to provide a uniqueness guarantee anymore, but you could still make a mistake with `bin/repository move-paths` by accident, and it's a little cleaner to pull them out into their own column with a key.

(We still don't -- and, largely can't -- guarantee that two paths aren't //equivalent// since one might be symlinked to the other, or symlinked only on some hosts, or whatever, but the primary value here is as a sanity check that you aren't goofing things up and pointing a bunch of repositories at the same working copy by mistake.)

Test Plan:
  - Ran migrations.
  - Grepped for `local-path`.
  - Listed and moved paths with `bin/repository`.
  - Created a new repository, verified its local path populated correctly.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4039

Differential Revision: https://secure.phabricator.com/D15837
2016-05-04 16:09:52 -07:00
..
conduit Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
constants Give users a modal VCS choice when creating a new repository 2016-04-29 09:20:31 -07:00
customfield Move various other callsites away from callsigns 2016-01-04 06:54:42 -08:00
daemon Rough cut of repository cluster status panel 2016-04-12 05:38:10 -07:00
data Fix pht method calls 2015-02-10 18:57:45 +11:00
editor Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
engine Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
graphcache Remove duplicated duplicated words 2015-06-27 08:43:44 -07:00
mail Build separate mail for each recipient, honoring recipient access levels 2015-06-03 18:59:31 -07:00
management Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
phid Rough sketch of new repository URI editing 2016-04-29 09:21:00 -07:00
query Add repository URI view pages and IO/Display edit logic 2016-04-29 09:22:16 -07:00
response Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
search Reduce the total number of calls to getCallsign() 2016-01-02 04:23:06 -08:00
storage Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
worker Synchronize working copies before doing a "bypassCache" commit read 2016-04-22 08:11:43 -07:00