phorge-phorge/resources/sql/autopatches/20180120.auth.03.vcsdata.sql at dd8f588ac51bb178fb24aeb8f09ee1c0cd097d68 - revi-archive/phorge-phorge - SiliconForest Atelier

revi-archive/phorge-phorge

mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00

epriestley dd8f588ac5 Migrate VCS passwords to new shared password infrastructure

Summary:
Ref T13043. Migrate VCS passwords away from their dedicated table to new the new shared infrastructure.

Future changes will migrate account passwords and remove the old table.

Test Plan:
- Ran migrations.
  - Cloned with the same password that was configured before the migrations (worked).
  - Cloned with a different, invalid password (failed).
- Changed password.
  - Cloned with old password (failed).
  - Cloned with new password (worked).
- Deleted password in web UI.
  - Cloned with old password (failed).
- Set password to the same password as it currently is set to (worked, no "unique" collision).
- Set password to account password. !!This (incorrectly) works for now until account passwords migrate, since the uniqueness check can't see them yet.!!
- Set password to a new unique password.
  - Cloned (worked).
  - Revoked the password with `bin/auth revoke`.
  - Verified web UI shows "no password set".
  - Verified that pull no longer works.
  - Verified that I can no longer select the revoked password.
- Verified that accounts do not interact:
  - Tried to set account B to account A's password (worked).
  - Tried to set account B to a password revoked on account A (worked).
- Spot checked the `password` and `passwordtransaction` tables for saniity.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13043

Differential Revision: https://secure.phabricator.com/D18898

2018-01-23 10:56:13 -08:00

5 lines

265 B

SQL

Raw Blame History

 INSERT INTO {$NAMESPACE}_auth.auth_password
   (objectPHID, phid, passwordType, passwordHash, isRevoked,
     dateCreated, dateModified)
   SELECT userPHID, '', 'vcs', passwordHash, 0, dateCreated, dateModified
     FROM {$NAMESPACE}_repository.repository_vcspassword;