1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 17:58:47 +02:00
phorge-phorge/src/applications/files
epriestley ddb1f181c1 Simplify lightboxing and fix a few things
Summary:
Minor tweaks to lightboxes.

  - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it.
  - Make the lightbox go over the menu bar -- was it intentional that it wasn't?
  - Make 'jx-mask' use "position: fixed;" too.
  - Add a loading indicator.
  - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area.

I'm going to do a couple of other tweaks here but need to update JX.Mask.

Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1896

Differential Revision: https://secure.phabricator.com/D3795
2012-10-23 17:34:43 -07:00
..
application Introduce lightbox view for images 2012-10-22 19:06:56 -07:00
controller Simplify lightboxing and fix a few things 2012-10-23 17:34:43 -07:00
engine Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
engineselector Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
exception Fixing upload_max_filesize configuration directive 2012-06-26 13:20:05 +02:00
storage Introduce lightbox view for images 2012-10-22 19:06:56 -07:00
view Move "Macros" to a first-class application 2012-10-01 14:04:03 -07:00
PhabricatorImageTransformer.php Improve image thumbnailing and increase the size of Macro thumbnails 2012-10-08 13:26:10 -07:00