1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
phorge-phorge/webroot/rsrc/image
epriestley ddb1f181c1 Simplify lightboxing and fix a few things
Summary:
Minor tweaks to lightboxes.

  - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it.
  - Make the lightbox go over the menu bar -- was it intentional that it wasn't?
  - Make 'jx-mask' use "position: fixed;" too.
  - Add a loading indicator.
  - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area.

I'm going to do a couple of other tweaks here but need to update JX.Mask.

Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1896

Differential Revision: https://secure.phabricator.com/D3795
2012-10-23 17:34:43 -07:00
..
app Use sprites for (nearly) all application icons 2012-08-14 14:23:55 -07:00
icon Introduce lightbox view for images 2012-10-22 19:06:56 -07:00
apps.png Show commits in /audit/ 2012-02-28 21:10:39 -08:00
appstatus_empty.png Add a meta-application 2012-08-02 14:07:21 -07:00
appstatus_info.png Add a meta-application 2012-08-02 14:07:21 -07:00
appstatus_needs.png Add a meta-application 2012-08-02 14:07:21 -07:00
appstatus_okay.png Add a meta-application 2012-08-02 14:07:21 -07:00
autosprite.png Show all available action list icons in UIExamples 2012-10-23 12:00:28 -07:00
avatar.png Use a disk-based default avatar, not a database-based one 2012-04-27 17:44:10 -07:00
button_apps.png Add basic support for new navigation menu 2012-08-11 07:06:12 -07:00
button_content.png Add basic support for new navigation menu 2012-08-11 07:06:12 -07:00
button_menu.png Add basic support for new navigation menu 2012-08-11 07:06:12 -07:00
checker_dark.png Change background for image views in Differential 2012-08-13 17:21:16 -07:00
checker_light.png Change background for image views in Differential 2012-08-13 17:21:16 -07:00
credit_cards.png For discussion -- Stripe integration 2012-04-04 16:09:29 -07:00
divot.png Allow pages to use new "flexible" nav 2012-08-01 12:31:33 -07:00
grippy_texture.png Allow tasks to be subprioritized by drag-and-drop 2012-04-02 12:12:04 -07:00
lines.png Switch to new menubar 2012-07-30 16:09:14 -07:00
loading.gif Simplify lightboxing and fix a few things 2012-10-23 17:34:43 -07:00
logo_grey.png Minor, updates from @chad: 2012-08-20 16:03:56 -07:00
main_texture.png Minor, updates from @chad: 2012-08-20 16:03:56 -07:00
menu_texture.png Fix various app nav issues 2012-08-20 14:13:15 -07:00
nyan.gif Do something cooler 2012-08-22 08:20:23 -07:00
search.png Minor, reduce prominence of main menu icons. 2012-08-05 15:07:12 -07:00
sprite.png Import some code, some of which may be relevant to the project. 2011-01-17 19:31:39 -08:00