1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/metamta
epriestley 0a069cb55a Require a viewer to load handles
Summary:
Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess.

There are a few notable cases here:

  - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results.
  - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff.
  - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal.

Test Plan:
  - Grepped for all PhabricatorObjectHandleData references.
  - Gave them viewers.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D5151
2013-02-28 17:15:09 -08:00
..
__tests__ Delete license headers from files 2012-11-05 11:16:51 -08:00
adapter Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
application Installation & Uninstallion of Applications 2013-01-29 09:17:24 -08:00
constants Delete license headers from files 2012-11-05 11:16:51 -08:00
contentsource Convert simple phutil_render_tag() to phutil_tag() 2013-01-24 19:30:50 -08:00
controller Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
replyhandler Require a viewer to load handles 2013-02-28 17:15:09 -08:00
storage Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
view Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorMail.php Require a viewer to load handles 2013-02-28 17:15:09 -08:00
PhabricatorMetaMTAEmailBodyParser.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorMetaMTAWorker.php Convert phutil_render_tag(X, Y, phutil_escape_html(Z)) to phutil_tag 2013-01-24 19:08:55 -08:00