mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-02 19:52:44 +01:00
eeb7d517c2
Summary: I am not sure if it is by purpose but Phabricator now process paths like https://secure.phabricator.com/D1681-so-freaking-cool. The reason is that there are bunch of rules with missing '$' at the end. This mistake is so common and easy to create that I've rather removed all '$' and changed the way how the key is processed. I am not absolutelly sure if the '$' was missing in some rules by purpose but if it is the case then we should rather add explicit '.*'. This change is backwards compatible with custom maps ending with '$'. It is not compatible with paths not ending with '$' by purpose. Test Plan: Visit /, /differential/, /differential/stats/revisions/, /D1681. Run before and after: ./aphrontpath.php D123 ./aphrontpath.php D123-cool ./aphrontpath.php / ./aphrontpath.php differential ./aphrontpath.php differential/ ./aphrontpath.php differential/stats/revisions/ ./aphrontpath.php /file/data/x/PHID-FILE-y/z Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1745
68 lines
1.7 KiB
PHP
68 lines
1.7 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/**
|
|
* @group aphront
|
|
*/
|
|
final class AphrontURIMapper {
|
|
|
|
private $map;
|
|
|
|
final public function __construct(array $map) {
|
|
$this->map = $map;
|
|
}
|
|
|
|
final public function mapPath($path) {
|
|
$map = $this->map;
|
|
foreach ($map as $rule => $value) {
|
|
list($controller, $data) = $this->tryRule($rule, $value, $path);
|
|
if ($controller) {
|
|
foreach ($data as $k => $v) {
|
|
if (is_numeric($k)) {
|
|
unset($data[$k]);
|
|
}
|
|
}
|
|
return array($controller, $data);
|
|
}
|
|
}
|
|
|
|
return array(null, null);
|
|
}
|
|
|
|
final private function tryRule($rule, $value, $path) {
|
|
$match = null;
|
|
$pattern = '#^'.$rule.(is_array($value) ? '' : '$').'#';
|
|
if (!preg_match($pattern, $path, $match)) {
|
|
return array(null, null);
|
|
}
|
|
|
|
if (!is_array($value)) {
|
|
return array($value, $match);
|
|
}
|
|
|
|
$path = substr($path, strlen($match[0]));
|
|
foreach ($value as $srule => $sval) {
|
|
list($controller, $data) = $this->tryRule($srule, $sval, $path);
|
|
if ($controller) {
|
|
return array($controller, $data + $match);
|
|
}
|
|
}
|
|
|
|
return array(null, null);
|
|
}
|
|
}
|