mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 00:02:41 +01:00
55b44f53f8
Summary: We currently detect tab panels embedding themselves, but do not detect text panels embedding themselves with `{Wxx}`. Detect these self-embedding panels. I had to add a bit of a hack to pass the parent panel PHIDs to the rule. Generally, I got the Markup API kind of wrong and want to update it, I'll file a followup with details about how I'd like to move forward. Test Plan: Created a text panel embedding itself, a tab panel embedding a text panel embedding itself, a tab panel embedding a text panel embedding the tab panel, etc. Rendered all panels standalone and as `{Wxx}` from a different context. {F761158} {F761159} {F761160} {F761161} {F761162} Reviewers: chad, jbeta Reviewed By: chad, jbeta Differential Revision: https://secure.phabricator.com/D13999 |
||
---|---|---|
.. | ||
PhabricatorDashboardRemarkupRule.php |