1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 09:22:40 +01:00
phorge-phorge/src/applications/differential
epriestley dfc3506240 Prevent "Maniphest Tasks" field from creating empty comment when revisions are
updated

Summary:
  - If you update a revision with a nonempty "Maniphest Tasks" field, an empty
comment is posted (see T586).
  - The transaction email currently says "Attached revision 'Unknown
Differential Revision'", move attaching to "didWriteRevision()" to make sure the
object has been written.

Test Plan:   - Attached; updated a revision.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Maniphest Tasks: T685

Differential Revision: 1223
2011-12-16 13:32:52 -08:00
..
constants Add a relation table for Revisions to local commit hashes 2011-09-26 15:02:37 -07:00
controller Drive Differential landing page with DifferentialRevisionQuery, simplify UI 2011-12-16 13:21:54 -08:00
data/revisionlist Remove "Updated" view from Differential 2011-12-07 06:55:03 -08:00
editor Set user on auxiliary fields before validating them on template workflow 2011-12-02 15:14:39 -08:00
field Prevent "Maniphest Tasks" field from creating empty comment when revisions are 2011-12-16 13:32:52 -08:00
mail Move event framework from Phabricator to libphutil 2011-11-16 16:34:45 -08:00
parser/changeset Allow customized patterns for marking generated files. 2011-12-13 17:14:25 -08:00
query/revision Minor fix to D1186 to enforce ordering. 2011-12-16 13:32:16 -08:00
replyhandler Allow "!accept" to be enabled through configuration 2011-09-14 09:52:13 -07:00
storage Remove "Updated" view from Differential 2011-12-07 06:55:03 -08:00
tasks Enable updating task->revision assoc 2011-04-26 19:14:47 -07:00
view Add "tabindex" to Remarkup reference lists 2011-12-07 08:53:12 -08:00