1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 17:28:51 +02:00
phorge-phorge/webroot/rsrc/js/application
epriestley e0dbc57521 Stabilize scroll position as diffs load
Summary:
Try to lock the screen to whatever the user is looking at as we load changesets.

Notably, this improves the use case of taking a known action on a diff. Currently, you have to wait for everything to load or the comments keep getting scrolled down. After this change, the comments stay in the same place on screen.

Test Plan:
Raised the autoload changeset limit from 100 to 1000, looked at a 220 changeset diff.

  - Reloaded it while scrolled at the top; normal behavior (no scrolling).
  - Reloaded it, scrolled to the bottom. Comment area now stable.
  - Reloaded it, kind of scrolled around the middle? Behavior seemed stable/reasonable. This one is kind of heursitic so it's hard to say I'm getting it totally right or not, but it's less important than the "bottom" case.

Reviewers: vrana, btrahan, chad, dctrwatson

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D4774
2013-02-01 10:52:07 -08:00
..
aphlict Add loading state to notification menu. 2013-01-28 17:35:17 -08:00
conpherence Conpherence V1 2013-01-24 17:23:05 -08:00
core Make control + enter submit forms if a textarea is focused 2013-01-28 14:11:32 -08:00
countdown Make countdowns (internally) embeddable 2012-08-14 19:19:23 -07:00
differential Stabilize scroll position as diffs load 2013-02-01 10:52:07 -08:00
diffusion Update tables to table-kit view. 2013-01-11 11:24:35 -08:00
herald Clean up Login, Responsive Forms 2013-01-19 14:30:26 -08:00
maniphest Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
owners Allow excluding paths from package 2012-12-07 16:33:16 -08:00
phame Modernize blog UI 2012-10-15 14:50:12 -07:00
pholio Show all photos in a Pholio mock and allow switching between them 2013-01-28 11:19:01 -08:00
phortune For discussion -- Stripe integration 2012-04-04 16:09:29 -07:00
phriction Add a document preview to Phriction 2011-07-16 18:48:27 -07:00
ponder Simplify upvote/downvote implementation 2012-09-30 20:12:35 -07:00
projects Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
repository Don't open symbols on double click 2012-09-17 16:08:53 -07:00
transactions Make control + enter submit forms if a textarea is focused 2013-01-28 14:11:32 -08:00
uiexample Improve the implementation of Notifications 2012-10-08 15:22:29 -07:00