mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-14 19:02:41 +01:00
fab37aa4e3
Summary: Ref T12271. Currenty, when you "Accept" a revision, you always accept it for all reviewers you have authority over. There are some situations where communication can be more clear if users can accept as only themselves, or for only some packages, etc. T12271 discusses some of these use cases in more depth. Instead of making "Accept" a blanket action, default it to doing what it does now but let the user uncheck reviewers. In cases where project/package reviewers aren't in use, this doesn't change anything. For now, "reject" still acts the old way (reject everything). We could make that use checkboxes too, but I'm not sure there's as much of a use case for it, and I generally want users who are blocking stuff to have more direct accountability in a product sense. Test Plan: - Accepted normally. - Accepted a subset. - Tried to accept none. - Tried to accept bogus reviewers. - Accepted with myself not a reviewer - Accepted with only one reviewer (just got normal "this will be accepted" text). {F4251255} Reviewers: chad Reviewed By: chad Maniphest Tasks: T12271 Differential Revision: https://secure.phabricator.com/D17533 |
||
|---|---|---|
| .. | ||
| PhabricatorApplyEditField.php | ||
| PhabricatorBoolEditField.php | ||
| PhabricatorColumnsEditField.php | ||
| PhabricatorCommentEditField.php | ||
| PhabricatorConduitEditField.php | ||
| PhabricatorDatasourceEditField.php | ||
| PhabricatorDividerEditField.php | ||
| PhabricatorEditField.php | ||
| PhabricatorEpochEditField.php | ||
| PhabricatorFileEditField.php | ||
| PhabricatorHandlesEditField.php | ||
| PhabricatorIconSetEditField.php | ||
| PhabricatorInstructionsEditField.php | ||
| PhabricatorPHIDListEditField.php | ||
| PhabricatorPointsEditField.php | ||
| PhabricatorPolicyEditField.php | ||
| PhabricatorProjectsEditField.php | ||
| PhabricatorRemarkupEditField.php | ||
| PhabricatorSelectEditField.php | ||
| PhabricatorSpaceEditField.php | ||
| PhabricatorStaticEditField.php | ||
| PhabricatorStringListEditField.php | ||
| PhabricatorSubmitEditField.php | ||
| PhabricatorSubscribersEditField.php | ||
| PhabricatorTextAreaEditField.php | ||
| PhabricatorTextEditField.php | ||
| PhabricatorTokenizerEditField.php | ||
| PhabricatorUsersEditField.php | ||