1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/webroot/rsrc/js
epriestley e187519f00 When a transaction has no quote ref, render "@user wrote:" properly
Summary:
Fixes T12576. In Javascript, `data.ref` is null, which is getting turned into `/quote/?ref=null`.

The code already handles this case, just not with `ref=null` happening in JS:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php;b54adc6161c205e146fabb801ca53a44d94da444$47-52

Test Plan:
{F4913862}

  - Also quoted a normal comment on a normal object in a normal way.

Reviewers: amckinley, chad

Reviewed By: chad

Maniphest Tasks: T12576

Differential Revision: https://secure.phabricator.com/D17720
2017-04-18 09:51:53 -07:00
..
application When a transaction has no quote ref, render "@user wrote:" properly 2017-04-18 09:51:53 -07:00
core After a reconnect, repaint Conpherence thread state 2017-04-17 16:00:32 -07:00
phui Attempt to make dropdown item actions more consistent 2017-01-18 13:14:54 -08:00
phuix Sort "closed" results (like disabled users) to the bottom of typeaheads, but don't hide them completely 2017-04-14 13:01:48 -07:00